Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: add Uri.from declaration #10903

Merged
merged 1 commit into from
Mar 22, 2022
Merged

plugin: add Uri.from declaration #10903

merged 1 commit into from
Mar 22, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The commit adds the missing declaration for Uri.from in our theia.d.ts file (helps with the compatibility report). The static
method is already supported but now should officially be marked as such in our report.

How to test

  1. add the following test plugin uri-from-0.0.1.zip
  2. start the application
  3. execute the hello world command
  4. the outputted uri should work

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto
plugin: add Uri.from declaration
0a8a342 
The commit adds the missing declaration for `Uri.from` in our
`theia.d.ts` file (helps with the compatibility report). The static
method is already supported but now should officially be marked as such
in our report.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Mar 21, 2022
@vince-fugnitto vince-fugnitto self-assigned this Mar 21, 2022
colin-grant-work
colin-grant-work approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided plugin works, and the signature of the declaration matches the corresponding VSCode declaration. 👍

@vince-fugnitto vince-fugnitto merged commit 6d67d66 into master Mar 22, 2022
@vince-fugnitto vince-fugnitto deleted the vf/plugin-uri-from branch March 22, 2022 00:33
@github-actions github-actions bot added this to the 1.24.0 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees

@vince-fugnitto vince-fugnitto

Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vince-fugnitto @colin-grant-work