Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement icon reference rendering for plugin tree view tooltips #10899

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #10896 by implementing a small plugin for markdownit that adds a rule to replace icon references in plugin tree tooltips with icons.

How to test

  1. Open the application, install GitLens, open the Branches view and hover over a branch
  2. See this:

image

Instead of this:

image

  1. Perform the same check on other plugin icon references you're aware of.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added tree issues related to the tree (ex: tree widget) plug-in system issues related to the plug-in system labels Mar 17, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes work well, the icons can now be rendered in the tooltips 👍

@colin-grant-work
Copy link
Contributor Author

@msujew, you've done some work with markdown-it - does this seem like the right way to get rendered icons from it?

@colin-grant-work colin-grant-work merged commit 10953e7 into eclipse-theia:master Mar 23, 2022
@colin-grant-work colin-grant-work added this to the 1.24.0 milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system tree issues related to the tree (ex: tree widget)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Tooltip for plugin tree views does not render icons
2 participants