Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modified menuPath only for main action registration #10897

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Use modified menuPath only for main action registration #10897

merged 1 commit into from
Mar 17, 2022

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Mar 17, 2022 •
edited
Loading

What it does

Fixes #10889 by removing the reassignment of the menuPath argument. #10863 moved the reassignment up inappropriately: the new value was only supposed to be used in one place.

How to test

  1. Install GitLens plugin in both VSCode and Theia
  2. Open SCM panel
  3. Open Branches tree view
  4. Open context menu on any branch
  5. Observe that the context menu includes submenus for Copy As rather than subsections:

image

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added plug-in system issues related to the plug-in system menus issues related to the menu labels Mar 17, 2022
vince-fugnitto
vince-fugnitto approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that it works well 👍 The submenu provided by gitlens (ex: branches) now works correctly for both native and custom menus.

@colin-grant-work colin-grant-work merged commit 798f9d0 into eclipse-theia:master Mar 17, 2022
@colin-grant-work colin-grant-work deleted the bugfix/plugin-submenus branch March 17, 2022 21:06
@colin-grant-work colin-grant-work added this to the 1.24.0 milestone Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
menus issues related to the menu plug-in system issues related to the plug-in system
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Submenus are rendered as regular menus in plugin tree views
2 participants
@colin-grant-work @vince-fugnitto