debug: add multi-root support for add configurations #10875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
debug
vince-fugnitto
force-pushed
the
vf/add-configuration-multi-root
branch
from
690add0 to
ea7e981
Compare
colin-grant-work
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
- No workspace -> No op (we should perhaps hide the option in that case, but that's out of scope here)
- Unsaved workspace no launch -> creates and opens
.theia/launch.json - Unsaved workspace .vscode/launch -> opens
.vscode/launch.json - Unsaved workspace .theia/launch -> opens
.theia/launch.json - Unsaved workspace both/launch -> opens
.theia/launch.json - Saved empty workspace -> No op (see above)
- Saved single-root no launch -> creates and opens
.theia/launch.json - Saved single-root .vscode/launch -> opens
.vscode/launch.json - Saved single-root .theia/launch -> opens
.theia/launch.json - Saved single-root both/launch -> opens
.theia/launch.json - Saved multi-root select with no launch -> quick pick -> creates and opens
.theia/launch.json - Saved multi-root select with .vscode/launch -> quick pick -> opens
.vscode/launch.json - Saved multi-root select with .theia/launch -> quick pick -> opens
.theia/launch.json - Saved multi-root select with both/launch -> quick pick ->
.theia/launch.json
vince-fugnitto
force-pushed
the
vf/add-configuration-multi-root
branch
from
ea7e981 to
982cfe3
Compare
The commit adds support when executing `add configuration...` in a multi-root workspace where the user will first be prompted to choose the location for their config (choose the root) before adding. Previously, the first root was always chosen. Signed-off-by: vince-fugnitto <[email protected]> Co-authored-by: Liang Huang <[email protected]>
vince-fugnitto
force-pushed
the
vf/add-configuration-multi-root
branch
from
982cfe3 to
0c64755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #5166.
Closes: #8066.
The commit adds support when executing
add configuration...in a multi-root workspace where the user will first be prompted to choose the location for their config (choose the root) before adding. Previously, the first root was always chosen.How to test
I verified the changes using multiple different setups:
.vscodeand.theia).vscodeand.theia.Review checklist
Reminder for reviewers