-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align "Add Folder" visibility with VSCode #10840
Align "Add Folder" visibility with VSCode #10840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes work well for me 👍
I confirmed that:
- the command is available from the more toolbar item
- the command is available from the empty space in the explorer
- the command from the command palette works well, and is properly enabled
.theia-TreeContainer .ReactVirtualized__Grid__innerScrollContainer { | ||
margin-bottom: calc(var(--theia-ui-padding) * 3); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the extra space works well, do we want to add it to all trees or just the explorer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have it for all trees, since all trees have (by default, anyway) listeners for clicks targeting their nodes but no particular tree node, and that is only guaranteed to work if we ensure that all trees have some empty space. But I don't feel very strongly, since the Navigator is the only place I'm certain it matters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only seen it being used in vscode for the explorer so I asked the question, but it would probably benefit all trees so we can keep it generic like you have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming approval 👍
What it does
This PR aligns the visibility of the context menu command to add a folder to a workspace with the corresponding command in VSCode.
How to test
On
master
, the command is visible if:With these changes the command is visible if:
Review checklist
Reminder for reviewers