Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update requestretry dependency to resolve security vulnerability #10831

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request fixes a security vulnerability with the requestretry dependency.

How to test

  1. confirm that yarn audit | grep 'requestretry' yields no results.
  2. confirm that the build, and tests pass.
  3. confirm that downloading extensions through the vsx-registry works.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit updates the `requestretry` dependency to resolve a security
vulnerability with the package.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added the dependencies pull requests that update a dependency file label Mar 2, 2022
@vince-fugnitto vince-fugnitto self-assigned this Mar 2, 2022
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through https://github.com/FGRibreau/node-request-retry/blob/master/CHANGELOG.md and it looks fine to go from requestretry@3 to requestretry@7.

@paul-marechal paul-marechal merged commit 41a2f5b into master Mar 2, 2022
@paul-marechal paul-marechal deleted the vf/requestretry branch March 2, 2022 16:17
@github-actions github-actions bot added this to the 1.24.0 milestone Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants