Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined reference error when uninstalling extensions #10829

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Mar 2, 2022

What it does

Closes #10828

The previous code referenced the global variable location, which was undefined. The new code references the loop variable.

How to test

  1. Install an extension and uninstall it directly after that
  2. The UI should refresh
  3. The backend should have logged a message about the uninstalled location

Review checklist

Reminder for reviewers

@msujew msujew added the vsx-registry Issues related to Open VSX Registry Integration label Mar 2, 2022
Copy link
Contributor

@cdamus cdamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @msujew! Best to keep the code simpler, after all.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes work well 👍

  • undeploying extensions (ex: vsx-registry view) works well.
  • the logs regarding undeployment work well, and the approach is simpler.

@msujew msujew merged commit 88604fa into master Mar 2, 2022
@msujew msujew deleted the msujew/fix-plugin-uninstall branch March 2, 2022 14:36
@github-actions github-actions bot added this to the 1.24.0 milestone Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vsx-registry Issues related to Open VSX Registry Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninstall of extensions does not refresh the view due to logging error
3 participants