workspace: fix path alignment in dialogs #10814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit fixes the alignment when displaying the path in the workspace input dialog (ex: new file, new folder). The path is now correctly aligned with the icon. The change also includes the full path to the folder when hovering over the label (useful for multi-root workspaces especially). Signed-off-by: vince-fugnitto <[email protected]> Co-authored-by: shuyaqian <[email protected]>
vince-fugnitto
added
dialogs
msujew
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
The change is looking good to me 👍
There is one thing I noticed regarding the new title property. Like in other places we simply use URI#path.toString(), which leads to unexpected behavior on Windows:
However, that shouldn't be fixed by this PR but rather in #10591.
colin-grant-work
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes: #10567.
The pull-request updates the path alignment for the workspace dialog (ex:
new file,new folder) so that the content is properly aligned with the icon:The change also adds the folder path to the label's
title(displayed when hovering).How to test
new fileandnew folderare correctReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]
Co-authored-by: shuyaqian [email protected]