Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsx-registry: Increase query delay to 500ms #10813

Merged
merged 1 commit into from
Mar 1, 2022
Merged

vsx-registry: Increase query delay to 500ms #10813

merged 1 commit into from
Mar 1, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 28, 2022

What it does

This is part of an ongoing effort to improve on the heavy load hitting the ovsx servers. See eclipse/openvsx#379 for more info. VSCode uses a delay of 500ms as well. Since OVSX servers usually take a few seconds to return a search response anyway, this delay shouldn't be noticeable.

How to test

  1. Open the Network tab of your browser.
  2. Search for an extension (like typescript).
  3. Compare the amount of network requests to the /search endpoint with master.

Review checklist

Reminder for reviewers

@msujew msujew added the vsx-registry Issues related to Open VSX Registry Integration label Feb 28, 2022
colin-grant-work
colin-grant-work approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

  • reduces number of calls made to OVSX API
  • does not degrade user experience noticeably

@msujew msujew merged commit a9202c7 into master Mar 1, 2022
@msujew msujew deleted the msujew/increase-ovsx-delay branch March 1, 2022 10:41
@github-actions github-actions bot added this to the 1.24.0 milestone Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
vsx-registry Issues related to Open VSX Registry Integration
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@msujew @vince-fugnitto @colin-grant-work