Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenService to handle preferences #10810

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 28, 2022

What it does

Closes #10806

Refactors some code from PreferenceNodeRenderer into its own OpenHandler. This way we can target the OpenService purely instead of relying on some adhoc implementation. Also allows to open preferences from outside the preferences widget (VSCode does that a lot).

How to test

  1. Confirm that links/references to other preferences still work as expected.
  2. Download and install this sample extension.
  3. Search for hello command in the preference widget.
  4. Click on the link, a notification with Hello World! should appear.

Review checklist

Reminder for reviewers

@msujew msujew added the preferences issues related to preferences label Feb 28, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, and work well 👍

  • confirmed that commands contributed by plugins work well
  • confirmed that internal links work well (jumps to corresponding preference)
  • confirmed that external links (ex: documentation) work well

cc @colin-grant-work any concerns?

Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Neat, though I suspect no accident, that the internal preference links were already formatted to make this easy. 👍

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming approval :)

@msujew msujew merged commit ebd0fb8 into master Feb 28, 2022
@msujew msujew deleted the msujew/preference-open-handler branch February 28, 2022 16:42
@github-actions github-actions bot added this to the 1.24.0 milestone Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preferences: Support execute activationEvents command from 'markdownDescription'
3 participants