Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10696 Complete createStatusBarItem in window namespace from VSCode API #10754

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

ndoschek
Copy link
Contributor

What it does

This PR adds the missing createStatusBarItem overload in window namespace from VSCode API

  • Add createStatusBarItem overload in theia.d.ts to allow an item id as argument
  • Extend createStatusBarItem implementation in plugin-context
  • Adapt createStatusBarItem in status-bar-message-registry
  • Adapat StatusBarItemImpl to accept external ids

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek [email protected]

Fixes #10696

How to test

  1. Start the Theia browser example (which includes the vscode-builtin-json extension)
  2. Add a JSON file to your workspace that produces a schema resolution error. E.g. this snippet:
{
    "$schema": "http://invalid-schema-url"
}
  1. The extension should still add a status bar item (warning symbol) with the title Unable to resolve schema. Click to retry. on the right area of the Theia status bar.

Review checklist

Reminder for reviewers

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are looking good to me!

  • The existing JSON status bar item continues to work correctly
  • Using the overload to create a status bar item should work as well

I have a nitpick regarding the changed headers.

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Feb 15, 2022
…from VSCode API

- Add createStatusBarItem overload in theia.d.ts to allow an item id as argument
- Extend createStatusBarItem implementation in plugin-context
- Adapt createStatusBarItem in status-bar-message-registry
- Adapt StatusBarItemImpl to accept external ids

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <[email protected]>

Fixes eclipse-theia#10696
@msujew msujew merged commit 179b531 into eclipse-theia:master Feb 15, 2022
thegecko pushed a commit to ARMmbed/theia that referenced this pull request Feb 17, 2022
- Add createStatusBarItem overload in theia.d.ts to allow an item id as argument
- Extend createStatusBarItem implementation in plugin-context
- Adapt createStatusBarItem in status-bar-message-registry
- Adapt StatusBarItemImpl to accept external ids
@ndoschek ndoschek deleted the issues/10696 branch February 24, 2023 13:31
@ndoschek ndoschek restored the issues/10696 branch February 24, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete createStatusBarItem in window namespace from VSCode API
3 participants