-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uplift Monaco to VSCode v. 1.65.2 #10736
Uplift Monaco to VSCode v. 1.65.2 #10736
Conversation
ce0bdc7
to
98eba70
Compare
217643c
to
d1b500e
Compare
@msujew, this is still a ways off from being ready, but one problem that's arisen is that even strings copied from Monaco at a newer version aren't present in our current |
@planger, the one CI check failing here is Playwright, and as we've discussed, it's the change to the default value of |
@colin-grant-work I would suggest to extend the But, please feel free to just skip the test in this PR, so your PR is green, and I'll open an issue that we'll resolve soon. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add my approvement as well, since I already gave it unofficially at the dev-meeting. The change is looking good to me, thanks Colin!
Also - removes monaco/src/typings/monaco/index.d.ts which was restored in a merge - cleans up formating of `plugin-metrics-languages-main.ts - removes now-unused copy plugin import from webpack-generator.ts
Due to the Monaco uplift, we had to temporarily skip a test, because it affected the default preference regarding auto-save. To re-enable the test, we now explicitly set the auto save preference to `off` before the test. This way the preference value is ensured to be consistent. See also eclipse-theia#10736 Fixes eclipse-theia#10891 Change-Id: I6ab22a71848e174313a30f9121cb4b3dec363f12
Due to the Monaco uplift, we had to temporarily skip a test, because it affected the default preference regarding auto-save. To re-enable the test, we now explicitly set the auto save preference to `off` before the test. This way the preference value is ensured to be consistent. See also eclipse-theia#10736 Fixes eclipse-theia#10891 Change-Id: I6ab22a71848e174313a30f9121cb4b3dec363f12
Due to the Monaco uplift, we had to temporarily skip a test, because it affected the default preference regarding auto-save. To re-enable the test, we now explicitly set the auto save preference to `off` before the test. This way the preference value is ensured to be consistent. See also eclipse-theia#10736 Fixes eclipse-theia#10891 Change-Id: I6ab22a71848e174313a30f9121cb4b3dec363f12
Due to the Monaco uplift, we had to temporarily skip a test, because it affected the default preference regarding auto-save. To re-enable the test, we now explicitly set the auto save preference to `off` before the test. This way the preference value is ensured to be consistent. See also eclipse-theia#10736 Fixes eclipse-theia#10891 Change-Id: I6ab22a71848e174313a30f9121cb4b3dec363f12
Due to the Monaco uplift, we had to temporarily skip a test, because it affected the default preference regarding auto-save. To re-enable the test, we now explicitly set the auto save preference to `off` before the test. This way the preference value is ensured to be consistent. In order to do so, we add support for option preferences See also eclipse-theia#10736 Fixes eclipse-theia#10891 Change-Id: I6ab22a71848e174313a30f9121cb4b3dec363f12
Due to the Monaco uplift, we had to temporarily skip a test, because it affected the default preference regarding auto-save. To re-enable the test, we now explicitly set the auto save preference to `off` before the test. This way the preference value is ensured to be consistent. In order to do so, we add support for option preferences See also eclipse-theia#10736 Fixes eclipse-theia#10891 Change-Id: I6ab22a71848e174313a30f9121cb4b3dec363f12
Due to the Monaco uplift, we had to temporarily skip a test, because it affected the default preference regarding auto-save. To re-enable the test, we now explicitly set the auto save preference to `off` before the test. This way the preference value is ensured to be consistent. In order to do so, we add support for option preferences See also #10736 Fixes #10891 Change-Id: I6ab22a71848e174313a30f9121cb4b3dec363f12
What it does
Fixes #10387.
This PR has two main objectives:
import * as Monaco from '@theia/monaco-editor-core'
) vs. private API (import { whatever } from '@theia/monaco-editor-core/*'
)In addition, it includes the TypeScript source in the
@theia/monaco-editor-core
NPM package, so it is possible to simply click through to definitions in the source, making it easy to explore the Monaco code running in Theia.This PR does not (for the most part):
I've added a file called
uplift-journal.md
in packages/monaco - have a look there for some observations about the process. I will be migrating that content to documentation in the wiki over the next little while.How to test
Testing instructions can be found here.
Review checklist
Reminder for reviewers