Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dugite-extra, remove --ignore-engines #10722

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 8, 2022

What it does

I've pushed an update to dugite-extra which removes the node version constraint. This change makes use of the updated version and removes --ignore-engines where it is no longer needed.

How to test

  1. Build the application on a node version > 12.
  2. Assert that Yarn does not show an error when running without the --ignore-engines argument
  3. (optionally) Test the functionality of the @theia/git extension manually, tests should pass as well (CI is green)

Review checklist

Reminder for reviewers

@msujew msujew added the dependencies pull requests that update a dependency file label Feb 8, 2022
@vince-fugnitto
Copy link
Member

I've opened two IP Due Diligence issues related to the new dependencies:

@paul-marechal paul-marechal mentioned this pull request Feb 8, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍, I confirmed that the following works:

  • building with a newer version of node works, and no flag is needed
  • basic git functionality seems to work fine with the updates
  • the IP Due Diligence issues are approved and the license check

@msujew msujew merged commit 37ed897 into master Feb 8, 2022
@github-actions github-actions bot added this to the 1.23.0 milestone Feb 8, 2022
@vince-fugnitto vince-fugnitto deleted the msujew/update-dugite-extra branch February 8, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants