Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser compound launch #10720

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

thegecko
Copy link
Member

@thegecko thegecko commented Feb 7, 2022

Signed-off-by: thegecko [email protected]

What it does

Small PR to add a browser compound launch configuration to start the browser frontend and backend together.

Also added the plugin host to the compounds to aid with debugging the plugin host.

How to test

Run the compound launch config!

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the contributor experience issues related to the contributor experience label Feb 8, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thegecko thegecko merged commit 0ab1b92 into eclipse-theia:master Feb 8, 2022
@thegecko thegecko deleted the launch-browser branch February 8, 2022 13:06
@JonasHelming JonasHelming added this to the 1.23.0 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor experience issues related to the contributor experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants