Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #4783
Closes #10268
This implements compact nodes for
TreeNode
s with a single child that is also aCompositeTreeNode
and uses those services in theNavigatorTree
. It is based mostly on #10268.I also refactored the
createTreeContainer
method to reduce the amount of boilerplate you have to write to set up a custom tree. It's not really necessary, but it does both make it clearer to callers what they get in their container (interfaces define the full service set) and make it easier to override those services.How to test
api-samples
that has various structures of interest to compression. Open Theia or open that workspace directly.explorer.compactFolders
preference and observe that the tree compresses and uncompresses as expected.Review checklist
Reminder for reviewers