Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support VSCode WebviewView API #10705

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Support VSCode WebviewView API #10705

merged 1 commit into from
Feb 6, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 2, 2022

What it does

Closes #8740
Closes #10137

Implements the VSCode WebviewView API mostly based on the changes done by #10137.

How to test

  1. Install the webview-view-sample extension. (download here)
  2. Open the Calico Colors container in the explorer view.
  3. Assert that everything in there works as expected (opening/collapsing the view, adding colors, clearing colors)

Review checklist

Reminder for reviewers

@msujew msujew added vscode issues related to VSCode compatibility webviews issues related to webviews labels Feb 2, 2022
@vince-fugnitto vince-fugnitto self-requested a review February 2, 2022 17:48
vince-fugnitto
vince-fugnitto reviewed Feb 3, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the provided calico-colors plugin works well 👍

packages/plugin/src/theia-proposed.d.ts Outdated Show resolved Hide resolved
@msujew msujew force-pushed the msujew/webview-view-support branch from c9dd7c6 to f2fd241 Compare February 3, 2022 14:50
vince-fugnitto
vince-fugnitto approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍

I confirmed using the provided extension that:

  • the tree-view can be collapsed/expanded
  • colors can be added
  • colors can be updated
  • colors can be cleared

@msujew msujew merged commit 864c560 into master Feb 6, 2022
@github-actions github-actions bot added this to the 1.23.0 milestone Feb 6, 2022
mcgordonite pushed a commit to ARMmbed/theia that referenced this pull request May 9, 2022
@msujew @mcgordonite
Implement vscode WebviewView API (eclipse-theia#10705)
58e7db2
mcgordonite pushed a commit to ARMmbed/theia that referenced this pull request May 12, 2022
@msujew @mcgordonite
Implement vscode WebviewView API (eclipse-theia#10705)
335b127
mcgordonite pushed a commit to ARMmbed/theia that referenced this pull request May 12, 2022
@msujew @mcgordonite
Implement vscode WebviewView API (eclipse-theia#10705)
3aeda0b
mcgordonite pushed a commit to ARMmbed/theia that referenced this pull request May 13, 2022
@msujew @mcgordonite
Implement vscode WebviewView API (eclipse-theia#10705)
9e5468e
@msujew msujew deleted the msujew/webview-view-support branch May 18, 2022 14:33
mcgordonite pushed a commit to ARMmbed/theia that referenced this pull request Jun 30, 2022
@msujew @mcgordonite
Implement vscode WebviewView API (eclipse-theia#10705)
78dd2b4
mcgordonite pushed a commit to ARMmbed/theia that referenced this pull request Jun 30, 2022
@msujew @mcgordonite
Implement vscode WebviewView API (eclipse-theia#10705)
4a8ec38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@JonasHelming JonasHelming JonasHelming approved these changes

Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Implementation of registerWebviewViewProvider VSCode API
3 participants
@msujew @JonasHelming @vince-fugnitto