-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theia plugin API documentation #10695
Conversation
* Add documentation on how theia's plugin API works and how to extend it. * Add link to new documentation to README Contributed on behalf of STMicroelectronics. Signed-off-by: Lucas Koehler <[email protected]>
@lucas-koehler should we consolidate the documentation from the now three different documents into a single one instead (even as different sections in the document). Having three sources of information would mean that the information is harder to discover, and might become outdated more quickly. Any thoughts? It can either be a single wiki page or a document in the repo although having the wiki reduces the turnaround for the documentation updates from being merged. |
@vince-fugnitto The wiki makes it hard to receive contributions. Therefore, I would be in favor of removing our wiki page (in the Theia project) after this is merged (link the page to this document). About the Che document, the Che team has to decide on how to proceed. (@tsmaeder ) |
@vince-fugnitto Thanks for the feedback. From my POV the doc in this PR contains all relevant information present in the two linked wiki pages and could replace them. So I propose to go with @JonasHelming suggestion to remove the Theia wiki page (or link from it to the doc in case people have it saved as a reference somewhere) and let the che team decide on what to do with their wiki page :) |
I wrote something similar internally last week. Some additional areas we may want to cover:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it VSCode
or VS Code
? ;)
|
||
**Note** that it is not necessary to adapt these for implementing new plugin API. | ||
|
||
## Communication between plugin API and Theia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this benefit from a diagram?
@thegecko : Great suggestion with the link, I believe we have the right target document here explaining the different extension mechanism: https://theia-ide.org/docs/extensions/ |
* Unify VS Code spelling * Add link to Theia's extension mechanisms to additional links sessions * Add diagram for the main ext pattern * Wrap raw links Contributed on behalf of STMicroelectronics Signed-off-by: Lucas Koehler <[email protected]>
cd7d575
to
8ef0850
Compare
@thegecko Thanks for your review and ideas. I unified the VS Code spelling and added a link to the extension mechanism overview to the
I think this is now covered with linking the external doc
There is a link to a readme explaining how to add a new namespace in a separate extension. If this is not sufficient, I suggest tackling this separately
A link to an example sounds very helpful. I suggest you just add it to this doc once you are finished with that :) |
Maybe there's some stuff to be stolen from https://www.youtube.com/watch?v=KN2JUsFuEhU as well. Did I ever make the slide public on that one? |
Thanks for the updates, especially the diagram!
Yeah, I think this readme is quite poor. It misses bits out. |
* Add theia plugin API documentation * Add documentation on how theia's plugin API works and how to extend it. * Add link to new documentation to README Contributed on behalf of STMicroelectronics. Signed-off-by: Lucas Koehler <[email protected]>
Here's the example repo I mentioned outlining a custom API namespace implementation and upgrading functionality in a VS Code extension for Theia. Shall we add it to this doc? https://github.com/thegecko/vscode-theia-extension @JonasHelming , two things:
|
What it does
Contributed on behalf of STMicroelectronics.
Signed-off-by: Lucas Koehler [email protected]
Note: This documentation is partly based on existing documentations https://github.com/eclipse/che/wiki/Writing-Theia-plugin-API and https://github.com/eclipse-theia/theia/wiki/Theia-Plugin-Implementation.
Review checklist
Reminder for reviewers