Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip TypeScript: run reference code lens #10688

Merged
merged 1 commit into from
Jan 29, 2022
Merged

skip TypeScript: run reference code lens #10688

merged 1 commit into from
Jan 29, 2022

Conversation

paul-marechal
Copy link
Member

We'll need to un-skip this test sooner than later.

@paul-marechal paul-marechal mentioned this pull request Jan 29, 2022
Merged
1 task
vince-fugnitto
vince-fugnitto approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test has become increasingly problematic, I believe skipping it for the moment would be best 👍

@vince-fugnitto vince-fugnitto added the ci issues related to CI / tests label Jan 29, 2022
@paul-marechal paul-marechal merged commit edeee9c into master Jan 29, 2022
@paul-marechal paul-marechal deleted the skip-run-reference-code-lens branch January 29, 2022 04:44
@github-actions github-actions bot added this to the 1.23.0 milestone Jan 29, 2022
@paul-marechal paul-marechal mentioned this pull request Jan 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@colin-grant-work colin-grant-work Awaiting requested review from colin-grant-work

Assignees
No one assigned
Labels
ci issues related to CI / tests
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-marechal @vince-fugnitto