Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute path for "Copy relative path" outside of workspace #10674

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes a bug in the implementation of the Copy relative path command. If the file is outside the workspace, it now copies the absolute path.

How to test

  1. Open a file outside your current workspace.
  2. Open the editor context menu for that file.
  3. Run the Copy relative path command.
  4. Your copy buffer should contain the absolute path of the file. On master, it is empty.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added bug bugs found in the application commands issues related to application commands labels Jan 26, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

I confirmed for files outside the workspace the Copy Relative Path command will add the full path to the clipboard (similarly to vscode).

@colin-grant-work colin-grant-work merged commit e3f7b21 into master Jan 26, 2022
@colin-grant-work colin-grant-work deleted the bugfix/copy-relative-outside-workspace branch January 26, 2022 21:29
@github-actions github-actions bot added this to the 1.22.0 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application commands issues related to application commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants