Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'logUri' and 'extension' (partially) to PluginContext #10650

Merged
merged 4 commits into from
Jan 26, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions packages/plugin-ext-vscode/src/node/plugin-vscode-extension.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
/********************************************************************************
* Copyright (C) 2022 Red Hat, Inc.
colin-grant-work marked this conversation as resolved.
Show resolved Hide resolved
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0 which is available at
* http://www.eclipse.org/legal/epl-2.0.
*
* This Source Code may also be made available under the following Secondary
* Licenses when the conditions for such availability set forth in the Eclipse
* Public License v. 2.0 are satisfied: GNU General Public License, version 2
* with the GNU Classpath Exception which is available at
* https://www.gnu.org/software/classpath/license.html.
*
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
********************************************************************************/

/* eslint-disable @typescript-eslint/no-explicit-any */

import * as theia from '@theia/plugin';

export enum ExtensionKind {
UI = 1,
Workspace = 2
}

export interface VsCodeExtension<T> extends theia.Plugin<T> {
readonly extensionUri: theia.Uri;
readonly extensionPath: string;
extensionKind: ExtensionKind;
}

export interface VsCodeExtensionContext extends theia.PluginContext {
readonly extension: VsCodeExtension<any>;
}

export function asVsCodeExtension<T>(plugin: theia.Plugin<T> | undefined): VsCodeExtension<T> | undefined {
return plugin && Object.assign(plugin, {
extensionPath: plugin.pluginPath,
extensionUri: plugin.pluginUri,
extensionKind: ExtensionKind.UI // stub as a local VS Code extension (not running on a remote workspace)
});
}
26 changes: 3 additions & 23 deletions packages/plugin-ext-vscode/src/node/plugin-vscode-init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import * as theia from '@theia/plugin';
import { BackendInitializationFn, PluginAPIFactory, Plugin, emptyPlugin } from '@theia/plugin-ext';
import { VSCODE_DEFAULT_API_VERSION } from '../common/plugin-vscode-types';
import { asVsCodeExtension, ExtensionKind } from './plugin-vscode-extension';

process.env['VSCODE_PID'] = process.env['THEIA_PARENT_PID'];

Expand All @@ -28,11 +29,6 @@ let defaultApi: typeof theia;
let isLoadOverride = false;
let pluginApiFactory: PluginAPIFactory;

export enum ExtensionKind {
UI = 1,
Workspace = 2
}

export const doInitialization: BackendInitializationFn = (apiFactory: PluginAPIFactory, plugin: Plugin) => {
pluginsApiImpl.set(plugin.model.id, createVSCodeAPI(apiFactory, plugin));
plugins.push(plugin);
Expand All @@ -50,10 +46,10 @@ function createVSCodeAPI(apiFactory: PluginAPIFactory, plugin: Plugin): typeof t
// use Theia plugin api instead vscode extensions
(<any>vscode).extensions = {
get all(): any[] {
return vscode.plugins.all.map(p => asExtension(p));
return vscode.plugins.all.map(p => asVsCodeExtension(p));
},
getExtension(pluginId: string): any | undefined {
return asExtension(vscode.plugins.getPlugin(pluginId));
return asVsCodeExtension(vscode.plugins.getPlugin(pluginId));
},
get onDidChange(): theia.Event<void> {
return vscode.plugins.onDidChange;
Expand Down Expand Up @@ -96,19 +92,3 @@ function overrideInternalLoad(): void {
function findPlugin(filePath: string): Plugin | undefined {
return plugins.find(plugin => filePath.startsWith(plugin.pluginFolder));
}

function asExtension(plugin: any | undefined): any | undefined {
if (!plugin) {
return plugin;
}
if (plugin.pluginPath) {
plugin.extensionPath = plugin.pluginPath;
}

if (plugin.pluginUri) {
plugin.extensionUri = plugin.pluginUri;
}
// stub as a local VS Code extension (not running on a remote workspace)
plugin.extensionKind = ExtensionKind.UI;
return plugin;
}
6 changes: 3 additions & 3 deletions packages/plugin-ext/src/plugin/plugin-context.ts
Original file line number Diff line number Diff line change
Expand Up @@ -724,13 +724,13 @@ export function createAPIFactory(
const plugins: typeof theia.plugins = {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
get all(): theia.Plugin<any>[] {
return pluginManager.getAllPlugins().map(plg => new Plugin(pluginManager, plg));
return pluginManager.getAllPlugins().map(plg => new TheiaPlugin(pluginManager, plg));
},
// eslint-disable-next-line @typescript-eslint/no-explicit-any
getPlugin(pluginId: string): theia.Plugin<any> | undefined {
const plg = pluginManager.getPluginById(pluginId.toLowerCase());
if (plg) {
return new Plugin(pluginManager, plg);
return new TheiaPlugin(pluginManager, plg);
}
return undefined;
},
Expand Down Expand Up @@ -972,7 +972,7 @@ export function createAPIFactory(
};
}

class Plugin<T> implements theia.Plugin<T> {
export class TheiaPlugin<T> implements theia.Plugin<T> {
id: string;
pluginPath: string;
pluginUri: theia.Uri;
Expand Down
5 changes: 4 additions & 1 deletion packages/plugin-ext/src/plugin/plugin-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import { Emitter } from '@theia/core/lib/common/event';
import { WebviewsExtImpl } from './webviews';
import { URI as Uri } from './types-impl';
import { SecretsExtImpl, SecretStorageExt } from '../plugin/secrets-ext';
import { TheiaPlugin } from './plugin-context';

export interface PluginHost {

Expand Down Expand Up @@ -383,7 +384,9 @@ export class PluginManagerExtImpl implements PluginManagerExt, PluginManager {
globalStoragePath: globalStoragePath,
globalStorageUri: Uri.file(globalStoragePath),
environmentVariableCollection: this.terminalService.getEnvironmentVariableCollection(plugin.model.id),
extensionMode: 1 // @todo: implement proper `extensionMode`.
extensionMode: 1, // @todo: implement proper `extensionMode`.
extension: new TheiaPlugin(this, plugin),
logUri: Uri.file(logPath)
};
this.pluginContextsMap.set(plugin.model.id, pluginContext);

Expand Down
13 changes: 13 additions & 0 deletions packages/plugin/src/theia.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3195,6 +3195,19 @@ export module '@theia/plugin' {
* other extensions in the host run in `ExtensionMode.Release`.
*/
readonly extensionMode: ExtensionMode;

/**
* The current extension instance.
*/
readonly extension: Plugin<any> | undefined;

/**
* The uri of a directory in which the extension can create log files. The directory might
* not exist on disk and creation is up to the extension. However, the parent directory is
* guaranteed to be existent.
* see - workspace.fs for how to read and write files and folders from an uri.
*/
readonly logUri: Uri;
}

/**
Expand Down