dep: update markdown-it dependency
#10634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit updates the `markdown-it` dependency in order to resolve a moderate security vulnerability. The change also makes `markdown-it` a shared dependency, and updates all usages to use the shared dep instead of redefining a version in individual `package.json`. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
added
security
msujew
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request addresses a security vulnerability (
Uncontrolled Resource Consumption in markdown-it) withmarkdown-it. The change also makesmarkdown-ita shared dependency (exported by@theia/core) since it is used by many packages, and they no longer need to reference it themselves at different versions.How to test
yarn audit --level=moderatedoes not produce any output formarkdown-it.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]