dep: replace colors with chalk
#10612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
quality
msujew
approved these changes
Jan 10, 2022
doc/Migration.md
Outdated
|
|
||
| ```json | ||
| "resolutions": { | ||
| "**/colors": "1.4.0" |
There was a problem hiding this comment.
Maybe we can be more generic and not assume the version needed, so long as it's not the newest one? e.g.:
"**/colors": "<=1.4.0"
There was a problem hiding this comment.
I confirmed that <=1.4.0 works correctly when building a downstream application, and adjusted the migration documentation.
The commit replaces the `colors.js` dependency with `chalk` due to a recent deliberate breakage by the author. The `chalk` dependency is a well maintained alternative by the open-source community. The change also includes a migration guide update so that downstream applications can include a resolution in their products if necessary. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/chalk
branch
from
cb806ab to
05f009f
Compare
marcdumais-work
approved these changes
Jan 13, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request updates the problematic colors.js dependency with chalk. In addition, the migration guide was also updated to include a note about the possibility of using resolutions in order not to pull the problematic dependency version (which may be pulled transitively through
electron-rebuildfor example).How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]