core: properly handle localhost uris on Electron #10590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
When running Electron `window.location` is not a standard HTTP(S) URL, so we cannot use it to determine the host where the backend is running. Resolve the remote host to `localhost` when running Electron.
paul-marechal
force-pushed
the
mp/localhost-links
branch
from
2c08b62 to
bb5c2bd
Compare
|
This looks pretty reasonable to me. It leaves a little bit more room for later customization than #10574. |
colin-grant-work
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
This looks good to me. @AlexandraBuzila, does this address your concerns with the current handling of localhost?
vince-fugnitto
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
I confirmed that the changes work well 👍
On master, using echo localhost:3000 in the terminal and attempting to click the link results in the following error:
cat: standard output: Bad file descriptor
sh: echo: I/O error
The same use-case works well with this change (the link is opened in an external browser).
Thank you for the changes, they work for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Electron
window.locationis not a standard HTTP(S) URL,so we cannot use it to determine the host where the backend is running.
Resolve the remote host to
localhostwhen running Electron.Closes #10574
How to test
Review checklist
Reminder for reviewers