Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation in createButton #10564

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

shuyaqian
Copy link
Contributor

@shuyaqian shuyaqian commented Dec 20, 2021

Signed-off-by: shuyaqian [email protected]

What it does

add translation in buttons

How to test

Review checklist

Reminder for reviewers

@shuyaqian shuyaqian changed the title add translation in buttons Add translation in createButton Dec 20, 2021
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @msujew, anything you'd add?

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colin-grant-work Looks good to me as well 👍

@colin-grant-work colin-grant-work merged commit a59118d into eclipse-theia:master Dec 22, 2021
@vince-fugnitto vince-fugnitto added the localization issues related to localization/internalization/nls label Jan 27, 2022
@vince-fugnitto vince-fugnitto added this to the 1.22.0 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants