-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the sash when the left/right side panel is collapsed and when the horizontal container is collapsed #10561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
- No sash appears, when the side panel is hidden (left/right)
- Sashes on view containers only appear when the container above is expanded.
I have a minor comment, but aside from that it looks good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes work well for me 👍
- confirmed that the
sash
does not display if the view is hidden in sidepanels - confirmed that the
sash
correctly displays if the view is not hidden in sidepanels - confirmed that there are no visible regressions
@vince-fugnitto @msujew : I think we can merge this!? |
@JonasHelming Thanks for the heads-up, I merged it! |
What it does
before.mov
now.mov
How to test
GitLens
orMaven for Java
extension from the VSX Registry (GitLens is used in the screenshot above)Review checklist
Reminder for reviewers