Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the sash when the left/right side panel is collapsed and when the horizontal container is collapsed #10561

Merged
merged 4 commits into from
Feb 1, 2022

Conversation

kaiyue0329
Copy link
Contributor

@kaiyue0329 kaiyue0329 commented Dec 17, 2021

What it does

  • Hide the sash when the left/right side panel is collapsed (see the two videos for comparison)
before.mov
now.mov
  • Fix bug for the scenario in the left panel where the sash is visible when all horizontal containers are collapsed (please refer to the screenshot below for more details)
Before After
image image

How to test

  1. Verify that the sash is hidden when the left/right side panel is collapsed
  2. Verify that the sash for the left/right side panel functions properly (try updating its size and hoverDelay)
  3. Install GitLens or Maven for Java extension from the VSX Registry (GitLens is used in the screenshot above)
  4. Locate a horizontal container for the extension from the left panel. Without clicking on the horizontal container, verify that the sash is hidden when the container is collapsed

Review checklist

Reminder for reviewers

@kaiyue0329 kaiyue0329 changed the title Hide the sash when the left/right side panel is collapsed Hide the sash when the left/right side panel is collapsed and when the horizontal container is collapsed Dec 24, 2021
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

  • No sash appears, when the side panel is hidden (left/right)
  • Sashes on view containers only appear when the container above is expanded.

I have a minor comment, but aside from that it looks good to go.

packages/core/src/browser/shell/side-panel-handler.ts Outdated Show resolved Hide resolved
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well for me 👍

  • confirmed that the sash does not display if the view is hidden in sidepanels
  • confirmed that the sash correctly displays if the view is not hidden in sidepanels
  • confirmed that there are no visible regressions

@JonasHelming
Copy link
Contributor

@vince-fugnitto @msujew : I think we can merge this!?

@msujew msujew merged commit d5bb4e8 into eclipse-theia:master Feb 1, 2022
@msujew
Copy link
Member

msujew commented Feb 1, 2022

@JonasHelming Thanks for the heads-up, I merged it!

@JonasHelming JonasHelming added this to the 1.23.0 milestone Feb 2, 2022
@vince-fugnitto vince-fugnitto added the ui/ux issues related to user interface / user experience label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants