workspace: add workbenchState context key
#10550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
vscode
vince-fugnitto
commented
Dec 16, 2021
| if (this.workspaceService.opened) { | ||
| return this.workspaceService.isMultiRootWorkspaceOpened ? 'folder' : 'workspace'; | ||
| return this.workspaceService.isMultiRootWorkspaceOpened ? 'workspace' : 'folder'; |
There was a problem hiding this comment.
I believe the original code might have had the logic reversed.
| this.updateStyles(); | ||
| this.workspaceService.onWorkspaceChanged(() => { | ||
| this.updateEncodingOverrides(); | ||
| updateWorkspaceFolderCountKey(); | ||
| updateWorkspaceStateKey(); | ||
| updateWorkbenchStateKey(); |
There was a problem hiding this comment.
Do you expect that workspaceState and workbenchState may want to have different values in the future? In this code, they're updated in tandem and with the same values, so they could be combined.
The commit adds support for the `workbenchState` context key, which declares if there is no workspace (empty), a folder, or a workspace (multi-root) opened. Signed-off-by: vince-fugnitto <[email protected]>
Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/workenchState
branch
from
a91b9b4 to
ad52561
Compare
colin-grant-work
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10549
The pull-request adds support for the
workbenchStatecontext key, which declares if there is no workspace (empty), a folder, or a workspace (multi-root) opened.How to test
theiaas a workspace - confirm that themavenview in the explorer is not visibleReset Workbench Layout- confirm that themavenview in the explorer is not visiblepom.xmlin the workspace (one of the activation events for the view)Reset Workbench Layout- confirm that themavenview is now visibleReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]