Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick-input: alter styling of codicon to resemble vscode #10544

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

Archie27376
Copy link
Contributor

@Archie27376 Archie27376 commented Dec 15, 2021

What it does

Fixes #10389

This commit alters the appearance of the codicons that show in the Run Task menu to be similar to vscode.
The color has been changed from blue to one that follows the present color theme.
The background of the icon when hovering over is now a square and centered around the icon to be more aesthetically pleasing.

How to test

  • Start the application using theia as a workspace
  • Execute the command Run Task using F1
  • Hover over each task to notice the tail icon colored correctly with the theme
  • Hover over the tail icon for the hover background

Review checklist

Reminder for reviewers

Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes improve the theming, and I don't see any regressions.

@colin-grant-work colin-grant-work merged commit fad4231 into eclipse-theia:master Dec 22, 2021
@colin-grant-work colin-grant-work added quick-open issues related to the quick-open ui/ux issues related to user interface / user experience labels Dec 22, 2021
@vince-fugnitto vince-fugnitto added this to the 1.22.0 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick-open issues related to the quick-open ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quick-input: iconClass not styled correctly
3 participants