Removed deprecated activateTerminal method #10521

[abhisharsinha]

Signed-off-by: abhisharsinha [email protected]

What it does

Fixes: #10521

Removed the deprecated activateTerminal method. The deprecated method was called in two files which have been updated with the open method. The method definition was also removed.

How to test

No functionality was changed. The project builds without any error.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

@abhisharsinha please be sure to also properly fill out the issue template which seems to have been discarded.

[vince-fugnitto]

@abhisharsinha it looks like an invalid email was used to author the pull-request which of course ultimately fails the CI check for the eca:

From c2a52e3369adce0637f4623140fa4303b89ea699 Mon Sep 17 00:00:00 2001
From: root <[email protected]>
Date: Thu, 9 Dec 2021 22:29:21 +0530
Subject: [PATCH] Closes #10521

While you're fixing the authorship, can you also please update the commit title and message itself to provide more details than "closes #" 👍

[vince-fugnitto]

@abhisharsinha the changes look good to me, do you mind adding a breaking change note in the
changelog to mentioned that we now removed the deprecated method?

[abhisharsinha]

@vince-fugnitto This was my first open-source contribution. Thank you for guiding me through it.

[vince-fugnitto]

@abhisharsinha no problem! 👍 everything looks good, do you mind as one final step to squash your commits so only one is present?

[vince-fugnitto]

@abhisharsinha do you need any help to do the rebase?

[abhisharsinha]

@abhisharsinha do you need any help to do the rebase?

Yes. I had squased the commits but there was a merge conflict. I am unable to squash merge commit.

[vince-fugnitto]

@abhisharsinha I cleaned it up for you 👍 I'll wait for CI to pass.