Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated id/label fields from theia.Command #10512

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Dec 7, 2021

Signed-off-by: Thomas Mäder [email protected]

What it does

The command removes the id and label fields from the theia command interface which have been deprecated for > 3 years.

fixes #9271

How to test

Use anything that contributes a command from a plugins, for example a code lens. I used the java debugger's "run" code lens on a main method.

Review checklist

Reminder for reviewers

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I couldn't observe any regressions when executing the testing steps provided.

Although the changes are long overdue, do you mind adding a breaking entry in the changelog?

Copy link
Contributor

@caseyflynn-google caseyflynn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder force-pushed the 9271_remove_command_id_label branch from 27a0c2f to cf75927 Compare December 21, 2021 10:27
@tsmaeder tsmaeder merged commit 6cc312a into eclipse-theia:master Dec 21, 2021
@vince-fugnitto vince-fugnitto added the quality issues related to code and application quality label Jan 27, 2022
@vince-fugnitto vince-fugnitto added this to the 1.22.0 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Safe Command" mechanism is broken
4 participants