Align vscode: Set theme attributes to webview body element

[EstherPerelman]

Signed-off-by: Esther Perelman [email protected]

What it does

Align with vscode the ability to set webview style for a specific theme by adding the body data attributes: data-vscode-theme-name & data-vscode-theme-kind (See details here)

How to test

1. In theia project install webview-sample from sample-vsix.zip or download from here
2. Ctrl+shift+p + Cat coding: Start cat coding session
3. Open the developer tools and inspect the webview image - search for the body element...
4. Select the Preferences icon -> Color Theme and navigate between the themes
5. See the body attributes changing accordingly to the selected theme (you can use vscode theme extensions from the market place)

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

The changes look good to me. I can confirm that the added body attributes are applied correctly and are available during theme selection (using data-vscode-theme-kind="vscode-light" in the example):

2021-11-30.14-30-09.mp4

@vince-fugnitto Do the changes on getActiveTheme (in particular the return type) warrant an entry in the breaking changes log?

[vince-fugnitto]

@vince-fugnitto Do the changes on getActiveTheme (in particular the return type) warrant an entry in the breaking changes log?

Yes, changing the return value of a method, even if it is protected, would be a breaking change and should be added to the changelog 👍

[EstherPerelman]

Hi @msujew @vince-fugnitto thanks for your comments,
I pushed the changelog...

[msujew]

Thanks, the changes look good to me 👍

• Webview body-property based styling works for the different theme-types/names
• The previously set activeTheme class still works correctly

[msujew]

@EstherPerelman Do you mind resolving the conflict in the changelog? Afterwards, I will merge this PR.

[EstherPerelman]

@EstherPerelman Do you mind resolving the conflict in the changelog? Afterwards, I will merge this PR.

Done! thank you

[EstherPerelman]

@msujew why didn't you merge it? there are conflicts again... :(

[msujew]

@EstherPerelman Sorry, I didn't notice the update on this PR. If you update the conflicting files again, I will merge it today.

[EstherPerelman]

@EstherPerelman Sorry, I didn't notice the update on this PR. If you update the conflicting files again, I will merge it today.

rebased... thanks!