core: improve Deferred typings #10455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason `Deferred` objects allow you to resolve them with `undefined` even though the corresponding promise only mentions `T`. Remove the optional `value` when resolving. Default to `void` if `T` is unspecified.
|
I noticed this oddity while reviewing #10333 (comment) We shouldn't be able to resolve with |
colin-grant-work
approved these changes
Nov 24, 2021
Co-authored-by: Vincent Fugnitto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason
Deferredobjects allow you to resolve them withundefinedeven though the corresponding promise only mentionsT.Remove the optional
valuewhen resolving.Default to
voidifTis unspecified.How to test
Everything should build and work as before.
Review checklist
Reminder for reviewers