Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in Workspace: fix history for programmatically added text #10438

Merged

Conversation

gbodeen
Copy link
Contributor

@gbodeen gbodeen commented Nov 19, 2021

What it does

Fixes #10437 .

How to test

  1. Open Theia to e.g. the Theia repo. Open the search in workspace widget. Type a few things into the search field, pausing in between to let the search & history update happen. Use the up-and-down arrows to view the contents of the history.
  2. Open an editor, select an interesting word in it, and hit ctrl+shift+F to search for it. It will appear in the search input field of the SIW widget. Now use the up-and-down arrows to view the contents of the history, and the programmatically-added search string will be found in the history as it should be.

Review checklist

Reminder for reviewers

@gbodeen gbodeen force-pushed the gb/siw-history-bugfix-1 branch from 7424260 to d6b75ec Compare November 19, 2021 16:34
@vince-fugnitto vince-fugnitto added the search in workspace issues related to the search-in-workspace label Nov 19, 2021
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the issue exists on master and is addressed by these changes nicely 👍 Also, thanks for cleaning up the getElementById calls.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me and work well 👍


@gbodeen not related to your changes but do you mind adding the following to the replace and glob (include & exclude) inputs:

autoComplete='off'

Currently only the search input has this option off and I discovered the issue for other inputs when testing your changes:

@gbodeen gbodeen force-pushed the gb/siw-history-bugfix-1 branch from d6b75ec to 8271fc1 Compare November 22, 2021 20:28
@gbodeen
Copy link
Contributor Author

gbodeen commented Nov 22, 2021

do you mind adding the following to the replace and glob (include & exclude) inputs:
autoComplete='off'

Added ✅

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@colin-grant-work colin-grant-work merged commit a89ec61 into eclipse-theia:master Nov 24, 2021
@vince-fugnitto vince-fugnitto added this to the 1.20.0 milestone Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
search in workspace issues related to the search-in-workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search-In-Workspace history omits entries added by the 'Find in Files' command
4 participants