core: fix runtime-import-check errors
#10418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
approved these changes
Nov 17, 2021
The code resolves `runtime-import-check` errors present in `@theia/core`. The changes attempt to not introduce too many breaking changes by exporting `common` functionalities from the existing files. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/runtime-import-check-core
branch
from
a525a69 to
d83b708
Compare
|
@paul-marechal do you have any feedback on the approach taken in the pull-request, or would it be fine to merge? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request resolves
runtime-import-checkerrors from core by moving relevant code under their proper runtimes (browser vs common vs node). The changes attempt to not introduce too much breaking functionality by re-exporting with a note about deprecation. Fixing theruntime-import-checkerrors are important to ensure that downstream applications do not run into problems where they import themselves from packages that are designed to work for that runtime (but are incorrectly declared by us).How to test
There should not be a change in functionality:
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]