Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search-in-workspace: correct scrollbar display when no results #10402

Closed
wants to merge 1 commit into from

Conversation

smart-bo
Copy link
Contributor

@smart-bo smart-bo commented Nov 9, 2021

What it does

fix #10289
Correct unexpect scrollbar display when no results are present.
Make sure the change don't effect issue #9203

How to test

  • open the search-in-workspace widget
  • confirm that no search term is present
  • open the replace field (arrow)
  • scrolling the empty area
  • confirm no scrollbar show up
  • drag and drop sections between views, confirm it works well in different Theia versions

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the search in workspace issues related to the search-in-workspace label Nov 9, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes unfortunately cause a major regression when searching, the results are never visible:

image

@smart-bo smart-bo closed this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
search in workspace issues related to the search-in-workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search-in-workspace: scrollbar incorrectly displayed when no results are present
2 participants