dep: remove font-awesome-webpack
#10401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit removes `font-awesome-webpack` as a dependency since: - the dependency was outdated - the dependency is no longer maintained - the dependency has high security vulnerabilities - the dependency does not support newer versions of webpack The change now uses the already used `css-loader` and `url-loader` to load font-awesome icons and fonts. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
added
quality
msujew
reviewed
Nov 11, 2021
There was a problem hiding this comment.
The changes look good to me, font-awesome icons continue to work correctly:
One question before approving. When running yarn audit --level=high, I receive this output:
35 vulnerabilities found - Packages audited: 1810
Severity: 15 Low | 20 Moderate
Am I right in the assumption that this eliminates all high-rated vulnerabilities?
@msujew that's correct, the summary is always present after the audit, the new report now shows that all high level (and higher) vulnerabilities have been removed :) (along with work from #10381, #10391) Before the changes: After: |
msujew
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10400
The pull-request removes
font-awesome-webpackas a dependency since:The change now uses the already used
css-loaderandurl-loaderto load font-awesome icons and fonts.How to test
1, confirm that the build and start of the application is successful
2. confirm that
yarn audit --level=highdoes not yield vulnerability results forfont-awesome-webpack3. confirm that the use of
font-awesomeicons still works correctly (ex: replacing a codicon with the previousfa)Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]