plugin: reset validateInput on subsequent calls
#10396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
approved these changes
Nov 8, 2021
The commit resolves an issue when calling multiple `showInput` calls when providing and omitting `validateInput`. Previously, since the `validateInput` handler was cached, if a `showInput` call did not provide validation it would it a previous handler incorrectly. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/validate-input
branch
from
15dec27 to
0c8fa00
Compare
|
@msujew I cleaned up the pull-request further including fixing a similar potential issue with |
msujew
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10393
The pull-request fixes an issue where the
validateInputhandler is not reset on subsequentshowInputcalls leading to the input being incorrectly validated. The fix ensures that if ashowInputomitsvalidateInputthat it will reset the cached handler.How to test
validateInputshould not be preserved on subsequentshowInputcallsReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]