Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open VSX: add noselect to className #10373

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Open VSX: add noselect to className #10373

merged 1 commit into from
Nov 4, 2021

Conversation

Archie27376
Copy link
Contributor

What it does

Fixes: #10372

The commit adds noselect to the class name so the plugin text is
not selectable.

How to test

  • open extension widget
  • perform a search that yields results
  • individual plugin results should not have their inner content selectable

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the vsx-registry Issues related to Open VSX Registry Integration label Nov 2, 2021
vince-fugnitto
vince-fugnitto approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that it works correctly 👍

  • verified searched extensions in the view
  • verified builtin extensions in the view
  • verified installed extensions in the view

colin-grant-work
colin-grant-work approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the trick for plugin results of all kinds. 👍

@vince-fugnitto vince-fugnitto merged commit 51461aa into eclipse-theia:master Nov 4, 2021
@vince-fugnitto vince-fugnitto deleted the Plugin_NoSelect_1 branch November 4, 2021 11:58
@vince-fugnitto vince-fugnitto added this to the 1.20.0 milestone Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
vsx-registry Issues related to Open VSX Registry Integration
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Open VSX: plugin listing text should not be selectable
3 participants
@Archie27376 @vince-fugnitto @colin-grant-work