Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search-in-workspace: add noselect to line result nodes #10371

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

Archie27376
Copy link
Contributor

@Archie27376 Archie27376 commented Nov 2, 2021

What it does

Fixes: #10362

The commit adds noselect to the line result nodes so their inner text is
not selectable, aligning with the rest of the framework and vscode.

How to test

  • open search-in-workspace widget
  • perform a search that yields results
  • individual line results should not have their inner content selectable

Review checklist

Reminder for reviewers

@Archie27376 Archie27376 changed the title Search Toolbar: Added noselect option search-in-workspace: add noselect to line result nodes Nov 2, 2021
The commit adds `noselect` to the line result nodes so thier inner text
is not selectable, aligning with the rest of the framework and vscode.
@vince-fugnitto vince-fugnitto added search in workspace issues related to the search-in-workspace ui/ux issues related to user interface / user experience labels Nov 2, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that t works well 👍

  • the inner content for search-in-workspace line result nodes are no longer selectable
  • the changes work well when searching in a multi-root workspace
  • there is no regression when the node itself is selected

Copy link
Contributor

@alvsan09 alvsan09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also confirm that the solution works well and no regressions were detected 👍
thanks @Archie27376 !

@alvsan09 alvsan09 merged commit f09fc1a into eclipse-theia:master Nov 2, 2021
@vince-fugnitto vince-fugnitto deleted the SearchBar_NoSelect branch November 2, 2021 16:12
@vince-fugnitto vince-fugnitto added this to the 1.20.0 milestone Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
search in workspace issues related to the search-in-workspace ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search-in-workspace: tree nodes should not have selectable content
3 participants