core: fix new window command for the browser
#10364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit fixes the `new window` command for the browser which previously would open an incorrect page since the `hash` (`#`) was not part of the url since we build it ourselves. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
added
bug
alvsan09
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #10360
The pull-request fixes an issue with the
new windowcommand in the browser caused by 5abda1f.The change adds the missing hash (
#) for the fragment, which is ultimately used to open a new window without a workspace present.How to test
browser:
theia)new windownew windowcommand works from a window without a workspace presentelectron (regression):
theia)new windownew windowcommand works from a window without a workspace presentReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]