Implement multiroot Open Folder command

[colin-grant-work]

What it does

Fixes #10334 by adding handling for multiselection to the Open Folder... command.
Fixes #10366 by implementing resolveToAbsolute for URI's.

How to test

1. Use the 'Open Folder...' command.
2. Select multiple folders.
3. Observe that a new multi-root workspace is created and opened.
4. It should work from either an existing workspace or a no-workspace state.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: Colin Grant [email protected]

[kenneth-marut-work]

Looks great, though I found a case where I'm getting some odd behavior

• Start with an empty workspace (close your existing workspace if you need to)
• Open Folder and select multiple folders (this will create the untitledWorkspace)
• Don't save the workspace
• Open Folder and select some new folders
• Observe that a second window opens with a workspace consisting of the new folders, but the first window also changes its workspace to the second window's workspace

I believe that VSCode doesn't actually launch a second instance. You're first prompted to save your untitled workspace then it just swaps out the first workspace for the second

[colin-grant-work]

Looks great, though I found a case where I'm getting some odd behavior

• Start with an empty workspace (close your existing workspace if you need to)
• Open Folder and select multiple folders (this will create the untitledWorkspace)
• Don't save the workspace
• Open Folder and select some new folders
• Observe that a second window opens with a workspace consisting of the new folders, but the first window also changes its workspace to the second window's workspace

I believe that VSCode doesn't actually launch a second instance. You're first prompted to save your untitled workspace then it just swaps out the first workspace for the second

Thanks for checking it out. I have pushed a patch that should handle this better.

[colin-grant-work]

@vince-fugnitto, @paul-marechal, to fix #10366 I've added an implementation of Path.resolve to our Path class, which seems in the spirit of that class: it's probably mostly fine, but it's a bit weird that we have it.

Alternatively, we could follow VSCode and just include the NodeJS Path package in our browser packages.

Let me know what you think.

[msujew]

Thanks for checking it out. I have pushed a patch that should handle this better.

I just retested it but was still able to reproduce the issue in another configuration:

1. Open a multi-root workspace
2. Open a new window
3. Open another multi-root workspace using Open Folder in that new window
4. The old window now uses the new multi-root workspace as well

[colin-grant-work]

Thanks for checking it out. I have pushed a patch that should handle this better.

I just retested it but was still able to reproduce the issue in another configuration:

1. Open a multi-root workspace
2. Open a new window
3. Open another multi-root workspace using Open Folder in that new window
4. The old window now uses the new multi-root workspace as well

Fair enough. The problem is that we always generate the same untitled workspace. VSCode uses a time-stamped system so that every new untitled workspace is distinct, presumably with some cleanup when you leave the workspace behind. I will implement something similar.

[msujew]

The changes look good to me:

• Enables selecting multiple folders when running Open Folder
• Automatically creates an untitled workspace
• Displays a dialog asking to save untitled workspaces

The untitled workspace always containing a suffix (in the file explorer) isn't optimal, but I don't see a better way around that right now to prevent overwriting other untitled workspaces. I do have one suggestion, but that doesn't prevent this from getting merged.

[vince-fugnitto]

@colin-grant-work I noticed something:

• if no workspace is present, and we perform the open folder... with multiple folders, the dialog appears (which occurs on unload), selecting don't save will close the dialog and restart the application without a workspace present. In vscode this same use-case will open the untitled workspace which was my expectation as a user.

no-workspace.mp4

[colin-grant-work]

@vince-fugnitto, thanks for the review and good catch. I've updated the code not to delete an untitled workspace file on exit, and instead added code to the backend WorkspaceServer that deletes untitled workspaces files that aren't in the top 10 most recent workspaces used. It's not foolproof: if you've kept an untitled workspace open while you've opened a bunch of other workspaces, and then your backend goes down and you have to restart, then the logic would delete that file even though it's still in use. If you have any suggestions for how to perform some cleanup without the risk of deleting a file in use, I'm happy to hear them.