Rename HostedPluginServer, etc. #10352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Mäder <[email protected]>
vince-fugnitto
added
plug-in system
colin-grant-work
added
the
potentially-breaking
|
Could use a changelog entry, since anyone relying on the current name will see breakage. |
| @@ -240,7 +240,7 @@ export class JsonRpcProxyFactory<T extends object> implements ProxyHandler<T> { | |||
| try { | |||
| if (isNotify) { | |||
| connection.sendNotification(method, ...args); | |||
| resolve(); | |||
| resolve(undefined); | |||
There was a problem hiding this comment.
Rather change line 239 to be new Promise<void>(...
There was a problem hiding this comment.
No, the promise can yield a result if it's not a notification.
There was a problem hiding this comment.
OK I had not seen the code around it! Though is this required by TypeScript? It's often fine to just write resolve() when nothing is returned, and resolve(undefined) is usually a smell that the promise constructor is not aptly typed.
|
I'll get back to this one once I have time.... |
Signed-off-by: Thomas Mäder <[email protected]>
|
Ping @paul-marechal |
vince-fugnitto
approved these changes
Nov 22, 2021
| @@ -1,5 +1,5 @@ | |||
| # Change Log | |||
|
|
|||
| - [plugindev] Renamed HostedPlugin(Server|Client) to PluginDev(Server|Client) | |||
There was a problem hiding this comment.
I can fix it when I do the release changelog, but it should be in the form:
## v1.20.0 - 11/25/2021
[1.20.0 Milestone](https://github.com/eclipse-theia/theia/milestone/28)
<a name="breaking_changes_1.20.0">[Breaking Changes:](#breaking_changes_1.20.0)</a>
- [plugin] renamed `HostedPluginServer` and `HostedPluginServer` to `PluginDevServer` and `PluginDevClient` respectfully [#10352](https://github.com/eclipse-theia/theia/pull/10352)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Mäder [email protected]
What it does
Fixes: #10351
Renames
HostedPluginServerand related symbols.How to test
Make sure running plugins from source in a second instance of Theia still works ("Hosted Plugin: Debug Instance", etc.)
Review checklist
Reminder for reviewers