Fix #9697: tasks#taskExecutions not return running tasks after refresh

[EstherPerelman]

Signed-off-by: Esther Perelman [email protected]

The issue: On TasksExtImpl constructor this.fetchTaskExecutions() was supposed to initial executions map with the running tasks so that when plugins ask for tasks#taskExecutions the executions map is returned with the running tasks full with the fetched ones,
But I found that the fetchTaskExecutions function never executes - because at this time (inside the constructor) the RPC not completely loading the proxy (setting a timeout of several seconds to the execution of fetchTaskExecutions - made it work).

The solution: So I wrote this PR in which I removed the call to fetchTaskExecutions from the TasksExtImpl constructor but added initTaskLoaded inside TasksExtImpl constructor.

What it does

Fix #9697

How to test (you can use the same steps to reproduce the issue on master)

1. upload the next plugin (inside the zip) to theia:
   task-sample.zip
2. create a sleep task, I used this:
   { "label": "sleep", "type": "shell", "command": "ping -n 88 127.0.0.1 >nul" }
3. run the sleep task
4. refresh the browser
5. ensure the task is still running by selecting Terminal -> Show Running Tasks
6. ctrl+shift+p -> Show Running Tasks **Length**
7. A message of running:1 need to be shown, Otherwise (the buggy result): running:0

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[tsmaeder]

The code looks good, as far as I can tell. However, I can't really test the PR, because for me, when I run a "sleep task" (timeout /T 500 on Window), I never see the task when I invoke "Show running tasks...".

[EstherPerelman]

The code looks good, as far as I can tell. However, I can't really test the PR, because for me, when I run a "sleep task" (timeout /T 500 on Window), I never see the task when I invoke "Show running tasks...".

I'm also on Windows, The task in the How to test doesn't work for you?

[tsmaeder]

@EstherPerelman

ensure the task is still running by selecting Terminal -> Show Running Tasks

That never shows the "sleep" task in master, even in master. What am I missing?

[msujew]

That never shows the "sleep" task in master, even in master. What am I missing?

@tsmaeder Running timeout /T 500 in Theia automatically ends the task for some reason (as if pressing a key):

Show running tasks also doesn't show anything for me in that case. However, running ping -n 88 127.0.0.1 >nul works fine for me:

[msujew]

Code looks good to me, and it seems to work well on both Windows and Ubuntu.

@tsmaeder Do you still plan on looking into this? I'll hold back my approval for now.

[tsmaeder]

@msujew code looks good to me and I think on test run is enough for the size of the change.

Running timeout /T 500 in Theia automatically ends the task for some reason (as if pressing a key):

While the task may be finished, the "cmd" process is still present in the Windows task manager. But I can't imagine this being related to the PR.

[msujew]

Alright, then I'll be approving this, thanks @EstherPerelman 👍

[alvsan09]

I have verified that this PR in Linux and it works as expected 👍

The code looks good to me as well !
Thanks @EstherPerelman !