Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted label color in action bar #10301

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

Archie27376
Copy link
Contributor

@Archie27376 Archie27376 commented Oct 19, 2021

What it does

Fixes: #10300

The commit alters the color of the next, previous and close labels in the action bar according to the present theme.

How to test

Follow steps to open the Browser:

  • yarn browser build
  • yarn
  • yarn browser start

Open .vscode/settings.json and trigger the command Go To Next Problem

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added monaco issues related to monaco ui/ux issues related to user interface / user experience labels Oct 19, 2021
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Archie27376 thanks that looks already quite good. While you're at this, I have a request. We recently changed the buttons to not transform their size when clicking on them and the monaco buttons do not seem to conform to that decision. Do you mind adding this rule as well?

.monaco-editor .monaco-action-bar .action-item.active {
	transform: none;
}

packages/monaco/src/browser/style/index.css Outdated Show resolved Hide resolved
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@msujew msujew merged commit c12d1ef into eclipse-theia:master Oct 21, 2021
@vince-fugnitto vince-fugnitto added this to the 1.19.0 milestone Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

monaco: fix peek widget styling
3 participants