fix descriptions missing in tree of plugin

[shuyaqian]

Signed-off-by: shuyaqian [email protected]

What it does

1. fix descriptions missing in tree of plugin
2. delete unused function: getCaption

How to test

1. install tree-view-sample
2. in theia, description of tree node is missing
   
   in vscode:
   

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[colin-grant-work]

I confirm that this allows descriptions in tree views to show. I also confirm that the getCaption function was not being used by code within the framework and that the behavior that it implemented - creating links from markdown-styled text in labels - is not consistent with VSCode's behavior. @tsmaeder, it looks like that behavior was implemented by a Red Hat developer - do you know if it's something you guys are using / rely on?

[RomanNikitenko]

I confirm that this allows descriptions in tree views to show. I also confirm that the getCaption function was not being used by code within the framework and that the behavior that it implemented - creating links from markdown-styled text in labels - is not consistent with VSCode's behavior. @tsmaeder, it looks like that behavior was implemented by a Red Hat developer - do you know if it's something you guys are using / rely on?

I think the behaviour was introduced within 27c0050, so it would be helpful if @vitaliy-guliy could take a look

@vitaliy-guliy
could you review the changes

[colin-grant-work]

The changes are reasonable and fix the stated problem. Unless @vitaliy-guliy objects, I'll plan to merge at the end of the week.

[colin-grant-work]

@shuyaqian, would you mind adding a brief breaking change notice in the changelog about removing the getCaption method? Then this should be good to go.

[shuyaqian]

@shuyaqian, would you mind adding a brief breaking change notice in the changelog about removing the getCaption method? Then this should be good to go.

Done.

[RomanNikitenko]

@shuyaqian
thanks for the fix!

@colin-grant-work @vince-fugnitto
thank you very much for the heads-up and time to check if the changes don't break our assembly!