-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Replace in Files
command to Edit
main-menu
#10242
Conversation
Hi @smart-bo, thank your for your contribution, the changes are looking quite promising. Do you mind giving this PR a more descriptive title? Also, would you please populate the How to test section of your PR for us reviewers to verify the expected behavior of your changes? |
Replace in Files
command to the edit
main-menuReplace in Files
command to Edit
main-menu
Thank you for your kind remind, the PR was modified, please check. |
packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx
Outdated
Show resolved
Hide resolved
packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx
Outdated
Show resolved
Hide resolved
e5de644
to
0d83c58
Compare
packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx
Outdated
Show resolved
Hide resolved
13cc36a
to
beac550
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the introduction of localization in Theia for the upcoming release, you'll have to rebase your PR and apply the suggestion below to your code. Sorry for the inconvenience.
Afterwards the PR is ready to go!
packages/search-in-workspace/src/browser/search-in-workspace-frontend-contribution.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smart-bo Thanks, that looks good to me.
Regarding the replace field focus issue: I would recommend that we tackle this in a separate issue, since that is a concurrency problem when running the refresh
method. The method automatically focuses the search field, but it does so in an async way (although it is not marked as async), which prevents us from awaiting the refresh and setting the focus to the replace field.
What it does
Fixes #10217
The commit includes the following changes:
Add the
replace in files
command to theedit
main-menu.It will open the search-in-workspace with the replace field expanded. If a selection exists in the editor, the search input will be pre-populated.
How to test
Review checklist
Reminder for reviewers