eslint: add plugin to warn against src imports
#10234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
linting
msujew
approved these changes
Oct 8, 2021
vince-fugnitto
force-pushed
the
vf/no-src-import
branch
2 times, most recently
from
1cbb94e to
498890f
Compare
The commit adds a new `no-src-import` rule to our custom eslint-plugin in order to warn against the use of `/src/` imports over `/lib/` which causes the build to fail and is not trivial for developers to identify as to why. The rule should help write developers more easily identify when they are using imports incorrectly. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/no-src-import
branch
from
498890f to
e0f1079
Compare
paul-marechal
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request adds a new
no-src-importrule to our custom eslint-plugin in order to warn against the use of/src/imports over/lib/which causes the build to fail and is not trivial for developers to identify as to why. The rule should help write developers more easily identify when they are using imports incorrectly.How to test
srcimports should produce errors.quick-fixshould exist to change thesesrcimports tolib.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]