core: Fix invisible svg icons regression #10232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/vsx-registry/src/browser/vsx-extensions-view-container.ts
Outdated
Show resolved
Hide resolved
msujew
force-pushed
the
msujew/fix-invisible-icons
branch
from
fbcc806 to
6419413
Compare
msujew
force-pushed
the
msujew/fix-invisible-icons
branch
from
6419413 to
b0d7d1a
Compare
vince-fugnitto
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
I confirmed with the sample that the svg icon is correctly displayed 👍
I verified that:
- it is correctly displayed when docked in the side-panels (left and right)
- it is correctly displayed as a tab (main and bottom area)
- I did not notice any regressions with codicons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #10231
Adds additional CSS rules that previously allowed to display svg based icons.
How to test
Review checklist
Reminder for reviewers