Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand variables in env section of tasks.json #10208

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

emilhammarstedtst
Copy link
Contributor

What it does

Fixes #10207

Contributed by STMicroelectronics

Signed-off-by: Emil HAMMARSTEDT [email protected]

How to test

See issue #10207 for reproducing

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilhammarstedtst thank you for your first contribution to the project 👍

Please be sure to rebase your branch against the latest master, it should resolve build problems you were experiencing, namely the untracked changes.

@vince-fugnitto vince-fugnitto added the tasks issues related to the task system label Oct 1, 2021
@emilhammarstedtst
Copy link
Contributor Author

I do not know why the build failed as the Ubuntu pipeline only says "Error:"

@paul-marechal paul-marechal merged commit 3453800 into eclipse-theia:master Nov 25, 2021
@paul-marechal paul-marechal added this to the 1.20.0 milestone Nov 25, 2021
@emilhammarstedtst emilhammarstedtst deleted the issue-#10207 branch November 26, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In tasks.json using the variableResolverService on env section does not resolve variables.
3 participants