Use fixed font-size for compact sidebar menu #10180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
@msujew I confirmed that it works well 👍
- the compact menu icon is correctly displayed
- performing a
zoom inorzoom outdisplays the icon correctly still
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Due to #9864, the width of the sidebar menu icons increased. The compact menubar visibility icon relied on a specific width which it used to calculate it's own size, resulting in a bleeding effect, as it's font-size was calculated as being
16.8px:This change fixes the size to 16px, regardless of the size of other icons.
How to test
Menu Bar Visibilitysetting tocompact.Review checklist
Reminder for reviewers