Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change panel location of viewsContainers to align to vscode. #10162

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Change panel location of viewsContainers to align to vscode. #10162

merged 1 commit into from
Sep 30, 2021

Conversation

shuyaqian
Copy link
Contributor

@shuyaqian shuyaqian commented Sep 24, 2021

Signed-off-by: shuyaqian [email protected]

What it does

Change panel location of viewsContainers to align to vscode.

How to test

Develop a plugin with viewsContainers like:

"viewsContainers": {
	"panel": [
		{
			"id": "package-explorer",
			"title": "Package Explorer",
			"icon": "media/dep.svg"
		}
	]
}

In vscode, this panel will be located in bottom.
But in theia, this panel will be located in left.

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍
I confirmed with a customized version of tree-view-sample that the tree-view is added to the bottom panel in the case of panel similarly to vscode.

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Sep 24, 2021
@vince-fugnitto vince-fugnitto merged commit 6abc784 into eclipse-theia:master Sep 30, 2021
@vince-fugnitto vince-fugnitto added this to the 1.18.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants